WHAT'S wrong with the codes?

Question

example..
enter a number: 5

factorial of 5 is::::
1
2
6
24
120

but this codes only displays 120... what is mistake here??

import java.io.*;
public class Factorial
{
// Evaluate n!
public static long factorial( int n )
{
if( n <= 1 ) // base case
return 1;
else
return n * factorial( n - 1 );
}

// Simple test program
public static void main( String [ ] args )throws Exception
{
int num=0;

BufferedReader keith=new BufferedReader(new InputStreamReader(System.in));
System.out.print("Enter a number:");
num=Integer.parseInt(keith.readLine());
System.out.println(factorial(num));

}
}

Answer 1

You need to put a print statement inside of your factorial function if you want to print intermediate values. This will require a little thought, and some modification of the code.

Play with it for a while, and you'll see what's going on.

Answer 2

The problem is that you have just one print statement 'System.out.printin(...)'.

What happens here is that when you call the function 'factorial(n)' This recursive procedure is called and the recursion continues till the function returns a value to the 'main()' function. As you can see, in between there are no print statements. Hence, only the last answer.

To get the desired output just replace the function 'factorial with the following

public static long factorial( int n )
{
int temp;

if( n <= 1 ) // base case
{
System.out.println(n);
return 1;
}
else
{
temp = n * factorial( n - 1 );
System.out.println(temp);
return temp;
}
}

Also, this will give 120 twice. So just make a call in the main function, ie, 'factorial(n);' instead of 'System.out.println(factorial(n));'

This will solve your problem

Answer 3

Your code is getting cut off, but you're only printing the total.

If you want to print the intermediate results, add a println to the factorial function.

Answer 4

The code of conduct....lol