Why doesnt this small PHP script work? To limit amount of charters in variables.?

Question

Whats wrong with this script? It's supposed to only echo the first 9 letters of the variable but echos the whole lot:

$string = 'hello one day i went';
function sub($string)
{
$Length = strlen($string);
if($Length > 9)
$string = substr($string, 0, 9) . "...";
return($string);
}
echo $string;
?>

It should echo just "hello one..."

Answer 1

function truncateString($input, $maxlength) {
//set local variable to be input minus leading / trailing spaces
$out = trim($input);

//truncate strings longer than maxlength
if(strlen($out) > $maxlength) {
$out = substr($out, 0, $maxlength) . '...';
}

//return output
return $out;
}

//set local variable
$mystring = "hello one day i went";

//echo the return value of the truncateString function
echo truncateString($mystring, 9);
?>

Answer 2

You were close. I modified the code a little:
//Initializing $string
$string = 'hello one day i went';

//Function code is largely ignored if you don't "call" it
//Call it by evaluation as in below
//If you dont do that, the next line of code is executed
//which echos your variable
$string = LimitString($string);

//I moved this line above the function
//This makes your code more readable
//Good practice is to keep your main line together
//Then Subroutines, then Functions
//Any code that is outside of your main line may be missed.
echo $string;

function LimitString($string)
{
$Length = strlen($string);
if($Length > 9)
{$string = substr($string, 0, 9) . "...";
return($string);
}
//You were missing the end bracket for the function
}
?>

Answer 3

the suited suited syntax is: If this would not paintings, then something on your server isn't set up wisely. in case you do no longer understand what you're doing, you likely shouldn't do it. installation insecure or incorrectly set-up cyber web servers is an extremely undesirable element (TM).

Answer 4

You are printing the string without formatting it. To get the desired result, you need to put:

echo sub($string);

That should do it.