How do I make it so this C++ program won't go into an infinite loop?

Question

I'm not used to using character values in my loops. For some reason it goes a little while. It may not be infinite, I never waited long.

#include
#include

using namespace std;

char builder_name[35];
char choice;

void add_builder()
{

while(choice != 'N' || choice != 'n')
{

ofstream builders;
builders.open ("builders.txt", ios::app);

cout << " Enter the name of a builder: ";
cin.get(builder_name, 35);
cin.ignore();

builders << builder_name << endl;

builders.close();

cout << " Would you like to add another builder? (enter (Y) or (N): ";
cin >> choice;

};

}

int main ()
{

add_builder();

return 0;

}

I changed it to:
while(choice != 'N' && choice != 'n' )

I also removed the uneccessary semicolon.

It still went infinite. I then changed it to while(choice != 'N') to eliminate the two options altogether. It still went infinite. Any other ideas. It seems like a simple problem. I'm just thinking too complicated probably.

Answer 1

while(choice != 'N' || choice !='n')
In this line and (&&) should be used instead of or(||).
Because if or( || ) is used, atleast one condition will be true for any input (n or N). so loop will go infinite. Hence we should use and(&&) to make the loop to terminate for either of the input n or N.
Semicolon should not be used at end of while loop.

Answer 2

The together as loop in no way breaks. and located the errors 1st U suggested together as(selection != 'N' && selection != 'n') that's impossible instead attempt this together as(selection != 'N' || selection != 'n') 2nd cout << " would you pick to function yet another builder? (enter (Y) or (N): "; cin >> selection; write this if(selection == 'N' || selection == 'n'){ wreck(); }else{ call of that function or declartion

Answer 3

Here's your problem - while(choice != 'N' || choice != 'n').
It's that ol' debbil double negative, in a different context. As long as choice isn't both N and n, it loops. If choice ==N, choice !=n is true and vice versa.

Answer 4

Change the line:
while(choice != 'N' || choice != 'n')
Into:
while(choice != 'N' && choice != 'n')