What factors contributed most to anglo-scottish amity and union between the 12th and 17th centuries?

Answer 1

The biggest factor was that the English wanted control of the Scottish and the Scotts did not (and still do not).

There was a factor of religion in that the Reformation took serious root in Scotland first and then there was the reversion when England was Protestant and Scotland not.

It gets complicated beyond these highpoints.