what makes life morally good according to james stockdale?

Answer 1

Stockdale was very much committed to stoic ideals, and spoke of them often. His interpretation of them is not so unusual really. Here's a quote from a speech he gave:

"...the good man is independent, autonomous, a law unto himself and a follower of the eternal guidance of duty and conscience."

Which sums up your question pretty well. It bears a little elaboration, though - as a stoic Stockdale means most of that literally. Being a 'law unto yourself' means taking charge of those things you can take charge of, which are primarily your own emotions and your own actions.

And letting fear (or the external universe) control you is the opposite of good. You cannot choose whether the universe can break your leg. But you can choose whether you will permit that to slow you down.

Answer 2

If he's a Stoic, then it's something like living in agreement with nature, though that slogan isn't very helpful, not without a lot of explanation.

So see: http://plato.stanford.edu/entries/stoicism/#Eth