Why is this php search script not echoing any results?

Question

Search results

$db = mysql_connect("removed");
mysql_select_db("cdcol", $db);
$query = "SELECT cds.interpret, cds.jahr, cds.id, cds.titel FROM cds WHERE name LIKE '%".$_POST[name]."%'";
$result = mysql_query($query);
while ($record = @mysql_fetch_assoc($result)){
while (list($fieldname, $fieldvalue) = each ($record)){
echo $fieldname.": ".$fieldvalue."
";
}
echo "
";
}
?>


click here to go back to the search page

Search for a disk

Please enter the name, or part of the name of the CD you are seeking:

Answer 1

First off, take out the @ before mysql_fetch_assoc. There may be an issue with the select that is causing this to break and so result won't be set.

If that is the case, fix the SQL.

I would also recommend using foreach instead of your second while -
foreach ( $record as $fieldname => $fieldvalue){
//do stuff
}
that will make it easier to read.

In general, don't suppress error messages using the @. The only time (and I discourage doing even this) it has a reason to be used is if a variable might or might not be set and it doesn't matter if it is or not. (for example a page that can process a form may or may not have all the variables set)